Skip to content

Don't absolutize sources outside of the sourceroot in TASTy #24491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

Don't absolutize sources outside of the sourceroot in TASTy #24491

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion compiler/src/dotty/tools/dotc/util/SourceFile.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@ object SourceFile {
val path = refPath.relativize(sourcePath)
path.iterator.asScala.mkString("/")
else
sourcePath.toString
jpath.toString
Copy link
Member

@hamzaremmal hamzaremmal Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The scaladoc says:

It returns the absolute path of `source` if it is not contained in `reference`.

By returning jpath instead of sourcePath when sourcePath.startsWith(refPath) == false breaks the contract in the documentation.

}

/** Return true if file is a script:
Expand Down
Loading