Skip to content

Conversation

@philibea
Copy link
Collaborator

@philibea philibea commented Dec 14, 2025

Summary

Type

  • Enhancement

Add tsconfig rule

 "isolatedModules": true,

also remove baseUrl
which will help to create better type.

Change how we properly export the type from SelectableCardGroupField inside @ultraviolet/form

Before:

export declare const SelectableCardGroupField: {
    <TFieldValues extends FieldValues, TFieldName extends FieldPath<TFieldValues> = FieldPath<TFieldValues>>({ legend, control, name, onChange, required, error: customError, columns, type, shouldUnregister, validate, ...props }: SelectableCardGroupFieldProps<TFieldValues, TFieldName>): JSX.Element;
    Card: ({ value, disabled, children, className, isError, onFocus, onBlur, tooltip, id, label, style, "data-testid": dataTestId, }: import("node_modules/@ultraviolet/ui/dist/components/SelectableCardGroup").CardSelectableCardProps) => import("react/jsx-runtime").JSX.Element;
};

After

declare const SelectableCardGroupFieldComponent: <TFieldValues extends FieldValues = FieldValues, TFieldName extends FieldPath<TFieldValues> = FieldPath<TFieldValues>>({ legend, control, name, onChange, required, error: customError, columns, type, shouldUnregister, validate, ...props }: SelectableCardGroupFieldProps<TFieldValues, TFieldName>) => JSX.Element;
type SelectableCardGroupFieldType = typeof SelectableCardGroupFieldComponent & {
    Card: typeof SelectableCardGroup.Card;
};
export declare const SelectableCardGroupField: SelectableCardGroupFieldType;

@philibea philibea requested review from a team and lisalupi as code owners December 14, 2025 16:40
@changeset-bot
Copy link

changeset-bot bot commented Dec 14, 2025

🦋 Changeset detected

Latest commit: df04c93

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@ultraviolet/illustrations Patch
@ultraviolet/nextjs Patch
@ultraviolet/themes Patch
@ultraviolet/fonts Patch
@ultraviolet/icons Patch
@ultraviolet/form Patch
@ultraviolet/plus Patch
@ultraviolet/config Patch
@ultraviolet/ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@philibea philibea force-pushed the tsconfig branch 8 times, most recently from 6e7d4a4 to d57cd84 Compare December 14, 2025 19:49
Signed-off-by: aphilibeaux <[email protected]>
@codecov
Copy link

codecov bot commented Dec 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.76%. Comparing base (c6de62e) to head (df04c93).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5890   +/-   ##
=======================================
  Coverage   91.75%   91.76%           
=======================================
  Files         335      335           
  Lines        7073     7079    +6     
  Branches     2734     2722   -12     
=======================================
+ Hits         6490     6496    +6     
  Misses        583      583           
Files with missing lines Coverage Δ
...s/form/src/components/CheckboxGroupField/index.tsx 76.31% <100.00%> (ø)
...ages/form/src/components/RadioGroupField/index.tsx 91.66% <100.00%> (ø)
...ectableCardGroupField/SelectableCardGroupField.tsx 82.60% <100.00%> (ø)
...omponents/SelectableCardOptionGroupField/index.tsx 61.11% <100.00%> (ø)
...ges/form/src/components/ToggleGroupField/index.tsx 95.45% <100.00%> (ø)
packages/ui/src/components/Avatar/index.tsx 89.28% <ø> (ø)
packages/ui/src/components/List/index.tsx 100.00% <100.00%> (ø)
packages/ui/src/components/Popup/index.tsx 92.07% <ø> (ø)
packages/ui/src/components/RadioGroup/index.tsx 86.66% <100.00%> (ø)
...es/ui/src/components/SelectableCardGroup/index.tsx 96.15% <100.00%> (ø)
... and 6 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5deba06...df04c93. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DorianMaliszewski
Copy link
Member

Miss changeset and pr title too

@philibea philibea merged commit 44aa0e5 into main Dec 16, 2025
18 checks passed
@philibea philibea deleted the tsconfig branch December 16, 2025 09:44
@scaleway-bot scaleway-bot mentioned this pull request Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants