Add DLL and ARM64 builds to MinGW workflow#274
Open
tobiasherzke wants to merge 2 commits intosccn:devfrom
Open
Add DLL and ARM64 builds to MinGW workflow#274tobiasherzke wants to merge 2 commits intosccn:devfrom
tobiasherzke wants to merge 2 commits intosccn:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extension of existing Msys2 MinGW workflow to also build liblsl as a DLL, and to also build for the Windows ARM64 target.
For openMHA, I would need a MinGW-compiled liblsl as DLL rather than as static library.
This pull request is divided into two commits:
The first commit extends the existing MinGW build matrix to support DLL builds and the Msys2 "clangarm64" target.
The second commit extends the same workflow in order to add these artifacts to releases.
I had to disable running the unit tests for the "clangarm64" target, as the tests would cause segfaults. Using the compiled clangarm64 liblsl DLL as a dependency for openMHA on Windows ARM64, however, worked fine for me.