Do not break when there are still running jobs.#236
Draft
CZYK wants to merge 1 commit intoschmittjoh:masterfrom
Draft
Do not break when there are still running jobs.#236CZYK wants to merge 1 commit intoschmittjoh:masterfrom
CZYK wants to merge 1 commit intoschmittjoh:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the
RunCommand::runJobsterminates when it receives aSIGTERMor the$maxRuntimeis expired. When this happens the running jobs are also terminated and remain asrunning.This change makes sure that
runJobswaits until all running jobs are finished and doesn't start any new jobs when it is instructed to shutdown.