Added check for date-formats#1141
Open
RyanWalker277 wants to merge 2 commits intoscrapinghub:masterfrom
Open
Conversation
Author
|
Hey @Gallaecio , I have fixed the test cases issue. It is now passing all the test cases. Kindly review it. |
Gallaecio
reviewed
Mar 15, 2023
Member
Gallaecio
left a comment
Gallaecio
left a comment
There was a problem hiding this comment.
Looking at the code, it feels to me like this change will have no effect whatsoever.
In any case, could you add a test based on the original issue that does not pass before your change and starts passing thanks to your change?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1020
Code changes
Added a function to check if an input
date_stringbelongs to specefieddate_formatsor notHelp Required
Even though I did an extremely small code change , It is failing some tests. Can any of the available maintainers help me determine the cause?
cc - @Gallaecio