fix: add compat with pandas 3 #3929
Merged
+196
−104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3929 +/- ##
==========================================
+ Coverage 76.89% 76.91% +0.01%
==========================================
Files 117 117
Lines 12450 12460 +10
==========================================
+ Hits 9574 9583 +9
- Misses 2876 2877 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Member
Author
|
Other seaborn bug under pandas 3: 
import pandas as pd
import seaborn as sns
from matplotlib import pyplot as plt
df = pd.read_parquet("sv.parquet")
x_axis_order = pd.Index(
[
"Gata2_0",
"Gata1_1",
"Fog1_2",
"EKLF_3",
"Fli1_4",
"SCL_5",
"Cebpa_6",
"Pu.1_7",
"cJun_8",
"EgrNab_9",
"Gfi1_10",
],
dtype="object",
)
sns.violinplot(
x="genes",
y="values",
data=df,
orient="v",
hue="genes",
color=None,
order=x_axis_order,
hue_order=x_axis_order,
cut=0,
inner=None,
linewidth=0.2,
density_norm="width",
)
plt.show(block=True) |
ilan-gold
approved these changes
Dec 30, 2025
Contributor
ilan-gold
left a comment
ilan-gold
left a comment
There was a problem hiding this comment.
is it just violin or everything with hue in seaborn? other than that looks good
| ] | ||
| overrides.matrix.deps.extra-dependencies = [ | ||
| { if = [ "pre" ], value = "anndata @ git+https://github.com/scverse/anndata.git" }, | ||
| { if = [ "pre" ], value = "pandas>=3rc0" }, |
Member
Author
There was a problem hiding this comment.
🤷 uv chose to resolve things without pandas 3rc0 without it
flying-sheep
commented
Dec 30, 2025
Co-authored-by: Ilan Gold <[email protected]>
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
hue_orderbreaks with pandas StringArray mwaskom/seaborn#3893