Skip to content

Fixes remaining sqlalchemy orms#309

Merged
havok2063 merged 2 commits intomainfrom
sqlacleanup
Feb 13, 2026
Merged

Fixes remaining sqlalchemy orms#309
havok2063 merged 2 commits intomainfrom
sqlacleanup

Conversation

@havok2063
Copy link
Collaborator

This PR fixes the database connections for the remaining sqlalchemy orms and removes the AbstractConcreteBase, mainly for consistency with sdss5db.

@havok2063 havok2063 self-assigned this Feb 13, 2026
@havok2063 havok2063 added the bug Something isn't working label Feb 13, 2026
@havok2063 havok2063 requested a review from albireox February 13, 2026 15:34
@codecov
Copy link

codecov bot commented Feb 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.44%. Comparing base (a298b6e) to head (93461ed).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #309      +/-   ##
==========================================
- Coverage   88.44%   88.44%   -0.01%     
==========================================
  Files          42       42              
  Lines       24212    24201      -11     
  Branches      463      463              
==========================================
- Hits        21415    21404      -11     
  Misses       2765     2765              
  Partials       32       32              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@albireox albireox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I did a couple tests with opsdb and targetdb and it seems to work fine.

@havok2063 havok2063 merged commit ecb8e29 into main Feb 13, 2026
10 checks passed
@havok2063 havok2063 deleted the sqlacleanup branch February 13, 2026 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants