Rewrite of flaky test #2195
Merged
Rewrite of flaky test #2195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahma
force-pushed
the
fix/rewrite-flaky-test
branch
from
9fcf29c to
fe00c8a
Compare
lahma
approved these changes
Nov 9, 2025
Collaborator
lahma
left a comment
lahma
left a comment
There was a problem hiding this comment.
Great, this has been annoying! 👍🏻
Contributor
Author
|
Ok, a failing |
This was referenced Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test
ShouldUnwrapPromiseWithCustomTimeoutdid randomly fail, so I tried to rewrite it to make it reliable.The test randomly failed with
which can happen if the system is under high load and the Task state machine didn't get CPU time to process the completed
Task.DelaywithinAsyncTestClass.ReturnDelayedTaskAsync().The rewrite attempts to fix that by basically always rejecting the unwrapping with a timeout of 1ms. This ensures that the provided custom timeout is used. The timeout should always happen, independent of when the async state machine got time to process the result.
The test above (
ShouldReturnedTaskConvertedToPromiseInJS) still checks the happy path for proper unwrapping.