Skip to content

Conversation

@tapple
Copy link

@tapple tapple commented Jan 13, 2026

Part of a set of PR's improving the definitions and keywords files in lsl and slua:


I significantly improved the luau types of most functions, so that luau-lsp gives less errors

Here's the diff for the generated slua-default.d.luau:

I added several fields to the definition file:

  • luaType: for when lua has a different or more-specific typing than lsl
  • luaReturn: same thing, but for return values
  • typeParameters: function generic<TYPE, PARAMETERS>()

I'm aware the plugin isn't the master source of lua typings. I can convert this PR to xml and submit a new PR in one of or more of these places, if desired:

@tapple tapple changed the title Type-fixes Luau type fixes for luau-lsp Jan 13, 2026
@tapple
Copy link
Author

tapple commented Jan 13, 2026

I tried merging this and #51 into the same branch, and there are only 3 trivial merge conflicts. I recommend merging #51 before this PR

@marchcat
Copy link

Pre-commit fails due to trailing whitespaces in src/shared/luadefsgenerator.ts and EOF in data/syntax_def_default.json.

@WolfGangS
Copy link
Contributor

WolfGangS commented Jan 20, 2026

The trailing whitespace is fixed in #50. It's a problem in the repo itself not this pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Type-check fails on valid statement (Vector multiplied by Number)

3 participants