feat: remove "requested" status of unmonitored movies during scan

[bonswouar]

Description

Quick & easy first implementation of Monitoring status support in Radarr:
When a movie - which was monitored before - is unmonitored, it won't appear as "requested" in Jellyseerr anymore

Issues Fixed or Closed

• Support monitor type for Radarr #695

[fallenbagel]

Converted to draft as the title states "WIP". Once it's ready feel free to make this pr ready for review

[bonswouar]

@fallenbagel Thanks I didn't think about the Draft feature

This is a WIP but it's basically working as I'd expect.
But I could update it with a more specific Monitoring status support if you think it's a good idea?

Only drawback is that if you have lots of Unmonitored movies in Radarr the scan should be slower, as it will request each unmonitored movie in db every time. Let me know if you have some thoughts about this

[bonswouar]

FYI I've been using this for months and it works as expected.
I suspect some other users might need this functionality, couldn't we merge it?

A more complete monitoring status support wouldn't be very useful imo, at least I didn't encounter any use case

[gauthier-th]

I don't think this should be merged if it's only Radarr. Could you implement the same logic for Sonarr seasons?
And shouldn't there be a setting to enable/disable this behavior? You may have unmonitored a movie/tv show but still want to keep it as requested.

[github-actions]

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

[gauthier-th]

It looks like the way things are done are not consistent between Radarr and Sonarr.
Why do you change the status of the Media entity for movies while you remove the SeasonRequest for series?
It may be linked to the issue you experienced.

[gauthier-th]

Why is this change necessary? Isn't the Sonarr scanner job enough?

[gauthier-th]

Also, not really related to this issue afaik, but still looks like the same kind of problem: I've noticed during my debugging that some Seasons are shown as "Available" although they don't contain any file in Sonarr (and are not monitored). I'd guess it's related to If the season is already marked as available, we force it to stay available (to avoid competing scanners), but I'm really not sure why this condition exists despite the comment (why not at least check if it has any episode instead of relying entirely on the previous status?!)

There are several jobs that update the status of a Media: Radarr/Sonarr jobs, and Jellyfin/Emby/Plex jobs, hence the comment about competing jobs.

[gauthier-th]

I still don't get the logic, why "If the season is already marked as available, we force it to stay available"?
What if the season is not available anymore??!

There is another job, "Media Availability Sync" that runs and mark the media as unavailable if necessary.

Is there something I should know about async deletion in typescript or something? This seems a bit random

It could come from your forEach loops. For instance in the processUnmonitoredSeason you are using an async function inside a forEach loops, but forEach loops don't wait the end of the async function to run the next item. IMHO It's better to use a for loop to iterate over an array than a forEach, because of this async function concurrency.

Let me review it one more time with the change you made and with your comments in mind.

[bonswouar]

Movies added and monitored in radarr will not show as requested. Can you test this. We don't do bidirectional sync like this.

Well I've just checked some random recently auto-imported (and monitored) movies in Radarr, I confirm it's still the case.

But that can make sense, specifically when they're unreleased: users shouldn't need/be able to request movies that will already be automatically downloaded when they're available I guess (at least in current Jellyseer's state; it could be useful if Movies can be requested by more than 1 user though).
I don't know if this was a bug that they originally appear as requested, but I like that users can focus to request only really-not-monitored movies!

[bonswouar]

If you believe so could you record and show me after adding a movie as monitored (a new movie) and then show me that exact same movie as marked as requested on jellyseerr?

So the ones added today don't appear as Requested as the sync didn't happen yet.
But added yesterday for example:

(But again, I think in current state of thing this is a wanted behaviour, as Monitored status isn't shown. Otherwise users will request "for nothing" all the unreleased movies that are already monitored! Be able to request an already-monitored movie could make sense only if more than 1 user is able to request a movie imo - they could then be seen more like a "follow" movie)

[fallenbagel]

If you believe so could you record and show me after adding a movie as monitored (a new movie) and then show me that exact same movie as marked as requested on jellyseerr?

So the ones added today don't appear as Requested as the sync didn't happen yet. But added yesterday for example:

(But again, I think in current state of thing this is a wanted behaviour, as Monitored status isn't shown. Otherwise users will request "for nothing" all the unreleased movies that are already monitored! This could make sense only if more than 1 user is able to request a movie imo - requests could then be seen more like a "follow" movie)

Oh so it does change the status. I see. iirc it wasn't like this previously as I remember being able to request ones already added to radarr (but i guess this was changed recently and since I haven't looked into it yet did not notice it). I will have a look at it.

[bonswouar]

iirc it wasn't like this previously as I remember being able to request ones already added to radarr (but i guess this was changed recently and since I haven't looked into it yet did not notice it)

This has been like that since I use Jellyseer I believe, so more than 1 year. But for sure at least since I've reported the issue (of movies that still appear as requested even after being unmonitored), so since April

If you "fix" that behavior, users will be even less informed about what's monitored or not though, right?

[fallenbagel]

This has been like that since I use Jellyseer I believe, so more than 1 year. But for sure at least since I've reported the issue (of movies that still appear as requested even after being unmonitored), so since April

We started as a fork during 2022. IIRC it did not work like that because I remember support requests about it (but i could be misremembering as well)

If you "fix" that behavior, users will be even less informed about what's monitored or not though, right?

Yes. Which is why i said I will look into it for a better way to handle this without requiring major refactors

[github-actions]

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

[github-actions]

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

[bonswouar]

Just a little reminder, if you have an idea for a better way of handling this let me know I could probably look into it.

Otherwise, I've been using my fork for more than a year and it works exactly as expected fyi

[github-actions]

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.