Skip to content

Expand proposal gossip and handling validation rules #2427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Expand proposal gossip and handling validation rules #2427

wants to merge 5 commits into from

Conversation

@masih
Copy link
Collaborator

@masih masih commented Oct 2, 2025

@masih
Expand proposal gossip and handling validation rules (#292)
15fa163 
Compared to the original Tendermint, Sei-Tendermint expands the proposal
structure to include a number of additional fields. Update the basic
validation logic to take into account additional fields when validating
proposals.

Add validation to both direct message handling and ambient gossip
handling to avoid propagation of an invalid proposal.

Expand tests to cover the additional execution paths at unit and reactor
integration level.
@masih masih requested review from sei-will and yzang2019 October 2, 2025 13:38
@codecov
Copy link

codecov bot commented Oct 2, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 41.50%. Comparing base (b3d73df) to head (83c13ac).

❌ Your project check has failed because the head coverage (31.12%) is below the target coverage (60.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2427      +/-   ##
==========================================
- Coverage   43.31%   41.50%   -1.81%     
==========================================
  Files        1575     1252     -323     
  Lines      136612   103259   -33353     
==========================================
- Hits        59174    42861   -16313     
+ Misses      72103    56624   -15479     
+ Partials     5335     3774    -1561
Flag Coverage Δ
sei-chain 31.12% <ø> (+<0.01%) ⬆️
sei-cosmos 52.56% <ø> (-0.01%) ⬇️
sei-db 47.60% <ø> (ø)
sei-tendermint ?
sei-wasmd 46.24% <ø> (ø)
sei-wasmvm 40.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 326 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@masih masih marked this pull request as draft October 8, 2025 09:22
@masih
Copy link
Collaborator Author

masih commented Oct 8, 2025

Marking as draft to reflect on additional feedback re duplicate validation execution.

@github-actions
Copy link

github-actions bot commented Nov 12, 2025

We truly appreciate your contribution and the time you’ve invested in this PR.
Before we can merge it, we’d love your help addressing the remaining feedback or sharing your perspective.
If we don’t hear back within 2 day(s), this PR will close automatically — but don’t worry, you can reopen it anytime when you’re ready to continue.

@github-actions
Copy link

github-actions bot commented Nov 18, 2025

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedNov 18, 2025, 9:38 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yzang2019 yzang2019 yzang2019 approved these changes

@sei-will sei-will sei-will approved these changes

Assignees

No one assigned

Labels

non-app-hash-breaking

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@masih @yzang2019 @sei-will