use flat cache for transient storage (#2270) #2508
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codchen
requested review from
philipsu522,
sei-will and
stevenlanders
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+260
to
+265
| for k, v := range ts.transientStates { | ||
| res.transientStates[k] = make(map[string]common.Hash, len(v)) | ||
| for k2, v2 := range v { | ||
| res.transientStates[k][k2] = v2 | ||
| } | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
Comment on lines
+262
to
+264
| for k2, v2 := range v { | ||
| res.transientStates[k][k2] = v2 | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
Comment on lines
+267
to
+269
| for k, v := range ts.transientAccounts { | ||
| res.transientAccounts[k] = v | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
Comment on lines
+271
to
+273
| for k, v := range ts.transientModuleStates { | ||
| res.transientModuleStates[k] = v | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
Comment on lines
+276
to
+278
| for k, v := range ts.transientAccessLists.Addresses { | ||
| res.transientAccessLists.Addresses[k] = v | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
Comment on lines
+282
to
+284
| for k2, v2 := range v { | ||
| res.transientAccessLists.Slots[i][k2] = v2 | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map Warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Testing performed to validate your change