Skip to content

Conversation

@codchen
Copy link
Collaborator

@codchen codchen commented Nov 10, 2025

Describe your changes and provide context

Flatten call stack of EndBlock

Testing performed to validate your change

unit test

@github-actions
Copy link

github-actions bot commented Nov 10, 2025

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedNov 21, 2025, 2:44 AM

@github-actions
Copy link

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedNov 10, 2025, 5:40 AM

@codecov
Copy link

codecov bot commented Nov 10, 2025

Codecov Report

❌ Patch coverage is 16.03774% with 89 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.33%. Comparing base (32dae87) to head (d9614e5).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
x/evm/keeper/abci.go 0.00% 75 Missing ⚠️
app/legacyabci/end_block.go 0.00% 7 Missing ⚠️
app/legacyabci/begin_block.go 0.00% 4 Missing ⚠️
app/apptesting/test_suite.go 0.00% 1 Missing ⚠️
app/test_helpers.go 0.00% 1 Missing ⚠️
x/epoch/keeper/abci.go 0.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (16.03%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2540      +/-   ##
==========================================
- Coverage   43.38%   43.33%   -0.06%     
==========================================
  Files        1585     1586       +1     
  Lines      136874   136804      -70     
==========================================
- Hits        59389    59281     -108     
- Misses      71988    72036      +48     
+ Partials     5497     5487      -10     
Flag Coverage Δ
sei-chain 42.96% <15.23%> (-0.17%) ⬇️
sei-cosmos 40.67% <ø> (-0.02%) ⬇️
sei-db 44.98% <ø> (+0.09%) ⬆️
sei-tendermint 47.24% <ø> (-0.04%) ⬇️
sei-wasmd 42.59% <20.00%> (-0.09%) ⬇️
sei-wasmvm 39.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
app/abci.go 68.51% <100.00%> (+4.68%) ⬆️
app/app.go 75.48% <100.00%> (-1.53%) ⬇️
sei-cosmos/tests/mocks/types_module_module.go 0.00% <ø> (ø)
sei-cosmos/types/module/module.go 51.75% <ø> (-3.01%) ⬇️
sei-cosmos/x/crisis/module.go 3.33% <ø> (+0.15%) ⬆️
sei-cosmos/x/feegrant/module/module.go 0.00% <ø> (ø)
sei-cosmos/x/gov/module.go 50.00% <ø> (-1.86%) ⬇️
sei-cosmos/x/staking/module.go 54.68% <ø> (-1.38%) ⬇️
sei-wasmd/x/wasm/module.go 40.00% <ø> (-1.18%) ⬇️
x/epoch/module.go 69.35% <ø> (-0.96%) ⬇️
... and 10 more

... and 13 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

k.RemoveFirstNTxHashes(ctx, DefaultTxHashesToRemove)

// Migrate legacy EVM receipts to receipt.db in small batches every N blocks
if ctx.BlockHeight()%LegacyReceiptMigrationInterval == 0 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think is not needed any more, @jewei1997 can you confirm?

@codchen codchen enabled auto-merge (squash) November 21, 2025 03:11
@codchen codchen merged commit 3163a2a into main Nov 21, 2025
57 of 61 checks passed
@codchen codchen deleted the tony/end-block branch November 21, 2025 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants