Skip to content

Conversation

@codchen
Copy link
Collaborator

@codchen codchen commented Nov 17, 2025

Describe your changes and provide context

Consolidate ante logics for CheckTx and separate Cosmos vs. EVM paths. Specifically stateless checks are explicitly encapsulated for future parallelizations.

Note that the refactor removed some duplicated param reads so it will affect gas usage for Cosmos txs and hence app hash breaking.

Testing performed to validate your change

unit tests

@github-actions
Copy link

github-actions bot commented Nov 17, 2025

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedNov 21, 2025, 3:38 AM

@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

❌ Patch coverage is 1.58046% with 685 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.40%. Comparing base (3163a2a) to head (a83f8e0).

Files with missing lines Patch % Lines
app/ante/cosmos_checktx.go 0.00% 340 Missing ⚠️
app/ante/evm_checktx.go 0.00% 226 Missing ⚠️
app/legacyabci/check_tx.go 0.00% 44 Missing ⚠️
app/legacyabci/recovery.go 0.00% 44 Missing ⚠️
app/abci.go 0.00% 30 Missing ⚠️
x/evm/ante/preprocess.go 50.00% 0 Missing and 1 partial ⚠️

❌ Your patch check has failed because the patch coverage (1.58%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2553      +/-   ##
==========================================
+ Coverage   43.33%   44.40%   +1.06%     
==========================================
  Files        1586      965     -621     
  Lines      136804    88734   -48070     
==========================================
- Hits        59286    39403   -19883     
+ Misses      72034    45650   -26384     
+ Partials     5484     3681    -1803     
Flag Coverage Δ
sei-chain 42.14% <1.43%> (-0.82%) ⬇️
sei-cosmos ?
sei-db 44.92% <ø> (-0.07%) ⬇️
sei-tendermint 47.11% <ø> (-0.15%) ⬇️
sei-wasmd 42.57% <100.00%> (-0.02%) ⬇️
sei-wasmvm 39.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
app/app.go 75.59% <100.00%> (+0.11%) ⬆️
x/evm/ante/preprocess.go 77.50% <50.00%> (ø)
app/abci.go 44.57% <0.00%> (-23.95%) ⬇️
app/legacyabci/check_tx.go 0.00% <0.00%> (ø)
app/legacyabci/recovery.go 0.00% <0.00%> (ø)
app/ante/evm_checktx.go 0.00% <0.00%> (ø)
app/ante/cosmos_checktx.go 0.00% <0.00%> (ø)

... and 641 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codchen codchen force-pushed the tony/split-ante branch 3 times, most recently from b92990e to c941aa3 Compare November 18, 2025 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants