-
Notifications
You must be signed in to change notification settings - Fork 857
refactor CheckTx #2553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
refactor CheckTx #2553
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (1.58%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #2553 +/- ##
==========================================
+ Coverage 43.33% 44.40% +1.06%
==========================================
Files 1586 965 -621
Lines 136804 88734 -48070
==========================================
- Hits 59286 39403 -19883
+ Misses 72034 45650 -26384
+ Partials 5484 3681 -1803
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
b92990e to
c941aa3
Compare
c159e4c to
a83f8e0
Compare
Describe your changes and provide context
Consolidate ante logics for CheckTx and separate Cosmos vs. EVM paths. Specifically stateless checks are explicitly encapsulated for future parallelizations.
Note that the refactor removed some duplicated param reads so it will affect gas usage for Cosmos txs and hence app hash breaking.
Testing performed to validate your change
unit tests