Merged
Conversation
Add bin/macnotifier shell script that wraps `open -n macnotifier.app --args ...` so users can simply run `./bin/macnotifier -m "test"` instead of invoking `open -n` directly. The wrapper handles -h/--help and -m validation directly so that output is visible in the terminal (open -n does not connect the app's stdout/stderr). It also converts --icon relative paths to absolute paths since open -n changes the working directory. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Adds a checked-in CLI wrapper script to launch the macnotifier.app bundle via open -n ... --args, and extends the repo’s shell-based test suite to exercise the wrapper behavior.
Changes:
- Introduce
bin/macnotifierwrapper foropen -n macnotifier.app --args ..., with help handling and--iconrelative-path normalization. - Add wrapper-focused assertions to
scripts/test.sh. - Stop ignoring the (now source-controlled) wrapper by removing the
/macnotifierentry from.gitignore.
Reviewed changes
Copilot reviewed 1 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
scripts/test.sh |
Adds basic tests to verify the wrapper exists and prints help / errors in-terminal. |
bin/macnotifier |
New Bash wrapper that pre-handles -h and -m presence and rewrites --icon relative paths before calling open. |
.gitignore |
Removes an ignore rule for a previously generated wrapper script. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Golden ratio grid: bubble 672×416 (21:13≈φ), top margin 272=34B (Fibonacci), rx=64=8B. Background #2d2d2d, bubble #c8beb4. Add CFBundleIconFile to Info.plist so macOS recognizes the icon. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Resolve symlinks so the wrapper works when invoked via symlink (e.g. Homebrew) - Validate that -m has a value, not just that the flag is present - Add tests for both cases Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 6 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bin/macnotifiershell script that wrapsopen -n macnotifier.app --args ...for convenient CLI usage-h/--helpand-mvalidation in the wrapper so output is visible in the terminal (open -ndoes not connect stdout/stderr)--iconrelative paths to absolute paths (needed becauseopen -nchanges CWD)/macnotifierfrom.gitignore(wrapper is now a checked-in source file, not a build artifact)scripts/test.shTest plan
./scripts/build.shsucceeds./scripts/test.shpasses (11/11)./bin/macnotifier -hshows usage in terminal./bin/macnotifier -m "test"sends a notification./bin/macnotifier -m "test" --icon relative/path.pngresolves relative path correctly🤖 Generated with Claude Code