Skip to content

fix: don't delete temp icon file before notification is enqueued #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
send merged 3 commits into from
Mar 1, 2026
Merged

fix: don't delete temp icon file before notification is enqueued #5

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c977652
fix: don't delete temp icon file before notification is enqueued
send Mar 1, 2026
4f0f28e
fix: use fixed temp directory for icon attachment
send Mar 1, 2026
bd16e15
fix: use UUID filename and clean up old icon copies on each notification
send Mar 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions Sources/main.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ class NotificationDelegate: NSObject, UNUserNotificationCenterDelegate {
withCompletionHandler completionHandler: @escaping () -> Void
) {
let userInfo = response.notification.request.content.userInfo

// Execute shell command
if let command = userInfo["execute"] as? String {
let task = Process()
Expand Down Expand Up @@ -55,21 +54,25 @@ class NotificationDelegate: NSObject, UNUserNotificationCenterDelegate {

// UNNotificationAttachment moves the file into its data store,
// so we must provide a temporary copy to avoid losing the original.
// UNNotificationAttachment moves the file into its data store at an
// indeterminate time, so the temp copy must outlive both init and center.add().
// A fixed temp directory is reused so at most one icon copy exists at a time.
func createIconAttachment(_ iconPath: String) -> UNNotificationAttachment? {
let resolvedPath = (iconPath as NSString).expandingTildeInPath
let sourceURL = URL(fileURLWithPath: resolvedPath)
let tmpDir = FileManager.default.temporaryDirectory
.appendingPathComponent(UUID().uuidString)
.appendingPathComponent("sh.send.macnotifier")
do {
try FileManager.default.createDirectory(at: tmpDir, withIntermediateDirectories: true)
let tmpURL = tmpDir.appendingPathComponent(sourceURL.lastPathComponent)
// Clean up previous icon copies (best-effort; may fail if another process still needs one)
if let old = try? FileManager.default.contentsOfDirectory(at: tmpDir, includingPropertiesForKeys: nil) {
for file in old { try? FileManager.default.removeItem(at: file) }
}
let ext = sourceURL.pathExtension.isEmpty ? "" : ".\(sourceURL.pathExtension)"
let tmpURL = tmpDir.appendingPathComponent(UUID().uuidString + ext)
try FileManager.default.copyItem(at: sourceURL, to: tmpURL)
let attachment = try UNNotificationAttachment(identifier: "icon", url: tmpURL, options: nil)
// The system moved the file out of tmpDir; clean up the empty directory.
try? FileManager.default.removeItem(at: tmpDir)
return attachment
return try UNNotificationAttachment(identifier: "icon", url: tmpURL, options: nil)
} catch {
try? FileManager.default.removeItem(at: tmpDir)
fputs("Warning: Failed to attach icon '\(iconPath)': \(error.localizedDescription)\n", stderr)
return nil
}
Expand Down