Cache values for 'is_available()' #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
|
@mayeut Is this what you were imagining for caching? The runtime doesn't actually speed up any for auditwheel, since the function |
mayeut
reviewed
Aug 25, 2025
|
|
||
|
|
||
| def _available_package_providers( | ||
| _is_available_cache: dict[type[PackageProvider], bool] = {} |
There was a problem hiding this comment.
I'm not sure I understand how caching works here.
Should we expect the default argument to be extended in this case ? (i.e. mutable default)
If that's the case, it should work although a bit hard to read/understand (and is that ok in the context of a no-gil build if called in parallel ?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.