Skip to content

Conversation

@tianhaoz95
Copy link
Contributor

@tianhaoz95 tianhaoz95 commented Nov 25, 2025

Motivation

Currently when we run longcat_flash it will error out with:

[2025-11-25 13:35:50 TP3 EP3] Scheduler hit an exception: Traceback (most recent call last):
  File "/home/zhoutianhao03/projects/sglang/python/sglang/srt/managers/scheduler.py", line 2712, in run_scheduler_process
  ...
  File "/home/zhoutianhao03/projects/sglang/python/sglang/srt/layers/communicator.py", line 187, in fetch_qkv_latent
    assert self.attn_inputs_ is not None
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError

this is because in #10568 set_attn_inputs() is skipped when qkv_latent_func == None, and later fetch_qkv_latent() will assert on this and fail.

Modifications

Make sure qkv_latent_func is set.

Accuracy Tests

After the change the following launch command runs and output normal tokens:

python3 -m sglang.launch_server \
    --trust-remote-code \
    --model $MODEL_PATH \
    --tp 8 \
    --ep-size 8 \
    --skip-server-warmup \
    --cuda-graph-bs 1 2 3 4 5 6 7 8 \
    --host 0.0.0.0 \
    --port 8080

gsm8k:

Accuracy: 0.950
Invalid: 0.000
Latency: 31.601 s
Output throughput: 386.859 token/s

Benchmarking and Profiling

gsm8k:

Accuracy: 0.950
Invalid: 0.000
Latency: 31.601 s
Output throughput: 386.859 token/s

same as when i revert to before it was broken:

Accuracy: 0.950
Invalid: 0.000
Latency: 34.700 s
Output throughput: 354.785 token/s

Checklist

@gemini-code-assist
Copy link
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@gemini-code-assist
Copy link
Contributor

It looks like you tried to use the /gemini retry command. This is not a recognized command. Please use /gemini help to see a list of available commands.

@tianhaoz95
Copy link
Contributor Author

/gemini help

@gemini-code-assist
Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

@tianhaoz95 tianhaoz95 closed this Nov 26, 2025
@tianhaoz95
Copy link
Contributor Author

Reopen to trigger gemini

@tianhaoz95 tianhaoz95 reopened this Nov 26, 2025
@tianhaoz95
Copy link
Contributor Author

gemini triage won't trigger close this one

@tianhaoz95 tianhaoz95 closed this Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant