Improve nightly tests

[Kangyan-Zhou]

• Fix the workflow to be triggered after version bump to be the new nvidia nightly tests
• Remove the outdated nightly tests
• Uncomment Minimax M2 tests

[gemini-code-assist]

Summary of Changes

Hello @Kangyan-Zhou, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the nightly test trace publishing script to support collecting and uploading trace files from multiple source directories. This enhancement improves the flexibility and efficiency of the trace collection process, enabling better utilization of test results by consolidating data from various test runs or configurations into a single published artifact.

Highlights

• Enhanced Trace Collection: The publish_traces.py script can now collect trace files from multiple specified directories, rather than being limited to a single one.
• New Utility Function: A new function, collect_all_trace_files, has been introduced to efficiently aggregate trace files from a list of provided directories.
• CLI Argument Update: The --traces-dir command-line argument has been updated to support multiple inputs, allowing users to specify several trace directories for collection.

Ignored Files

• Ignored by pattern: .github/workflows/** (4)
  • .github/workflows/bot-bump-kernel-version-to-sglang.yml
  • .github/workflows/bot-bump-sglang-version.yml
  • .github/workflows/nightly-test-nvidia.yml
  • .github/workflows/nightly-test.yml

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request refactors the trace publishing script to support multiple trace directories, which is a good improvement for flexibility. A new function collect_all_trace_files has been introduced to gather files from multiple sources, and the command-line interface has been updated accordingly. The changes are well-implemented and logical. My review includes a couple of suggestions to add type hints to the new and modified functions to improve code clarity and maintainability, aligning with practices seen in other scripts in the repository.

[gemini-code-assist]

For better code clarity and maintainability, consider adding type hints to the new collect_all_trace_files function. This aligns with practices in other scripts within the repository (e.g., scripts/ci/cleanup_hf_cache.py). You'll need to add from typing import List, Tuple at the top of the file.

Suggested change

	def collect_all_trace_files(traces_dirs, target_base_path):
	"""Collect trace files from multiple directories"""
	def collect_all_trace_files(traces_dirs: "List[str]", target_base_path: str) -> "List[Tuple[str, bytes]]":
	"""Collect trace files from multiple directories"""

[gemini-code-assist]

To improve code clarity and prevent potential type-related errors, please add type hints to the publish_traces function signature. This is consistent with the project's style in other scripts. You'll need to import List and Union from the typing module.

Suggested change

	def publish_traces(traces_dirs, run_id, run_number):
	"""Publish traces to GitHub repository in a single commit
	Args:
	traces_dirs: A single directory path (str) or list of directory paths
	run_id: GitHub run ID
	run_number: GitHub run number
	"""
	def publish_traces(traces_dirs: "Union[str, List[str]]", run_id: str, run_number: str) -> None:
	"""Publish traces to GitHub repository in a single commit
	Args:
	traces_dirs: A single directory path (str) or list of directory paths
	run_id: GitHub run ID
	run_number: GitHub run number
	"""