Skip to content

ci(shorebird): drop iOS Rust targets from macOS android shard#143

Merged
eseidel merged 1 commit intoshorebird/devfrom
es/fix-android-rust-targets
May 8, 2026
Merged

ci(shorebird): drop iOS Rust targets from macOS android shard#143
eseidel merged 1 commit intoshorebird/devfrom
es/fix-android-rust-targets

Conversation

@eseidel
Copy link
Copy Markdown

@eseidel eseidel commented May 8, 2026

Summary

The macOS android shard's Rust step lists aarch64-apple-ios and
x86_64-apple-ios alongside the host darwin targets. Those iOS targets
aren't used by anything the android shard links — gen_snapshot is built
for the host (the gn args force host_cpu="x64"). They're left over
from the old monolithic mac_setup.sh that built every macOS variant
in one script.

Why this matters now

On the namespace.so macOS Sequoia runner, building updater for
aarch64-apple-ios via cargo trips an iOS SDK / deployment-target
mismatch and fails the shard outright. Removing the unused targets lets
the android shard go green.

The actual ios-release shards still need the iOS Rust targets;
the SDK pin for those is handled separately in _build_engine
(IPHONEOS_DEPLOYMENT_TARGET=13.0).

Test plan

  • Bump engine SHA (or wait for next bump) so _build_engine's
    sharded workflow checks out a tree containing this fix
  • Re-trigger sharded build; android shard passes

The android shard on macOS builds gen_snapshot for the host (the
gn_args force host_cpu="x64"), so the only Rust targets it needs are
the host darwin ones. The two iOS targets were copy-pasted from the
old monolithic mac_setup.sh and never used by anything the android
shard links.

In addition to being dead work, building aarch64-apple-ios on the
Sequoia runner trips an iOS SDK / deployment-target mismatch in cargo
and fails the shard outright. Removing the unused targets keeps the
android shard green and leaves the actual ios-release shards as the
single place that needs the SDK fix (handled separately in
_build_engine).
@eseidel eseidel requested a review from bdero May 8, 2026 02:18
@eseidel eseidel enabled auto-merge (squash) May 8, 2026 02:19
@eseidel eseidel merged commit c063af1 into shorebird/dev May 8, 2026
8 checks passed
@eseidel eseidel deleted the es/fix-android-rust-targets branch May 8, 2026 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants