ci(shorebird): drop iOS Rust targets from macOS android shard#143
Merged
eseidel merged 1 commit intoshorebird/devfrom May 8, 2026
Merged
ci(shorebird): drop iOS Rust targets from macOS android shard#143eseidel merged 1 commit intoshorebird/devfrom
eseidel merged 1 commit intoshorebird/devfrom
Conversation
The android shard on macOS builds gen_snapshot for the host (the gn_args force host_cpu="x64"), so the only Rust targets it needs are the host darwin ones. The two iOS targets were copy-pasted from the old monolithic mac_setup.sh and never used by anything the android shard links. In addition to being dead work, building aarch64-apple-ios on the Sequoia runner trips an iOS SDK / deployment-target mismatch in cargo and fails the shard outright. Removing the unused targets keeps the android shard green and leaves the actual ios-release shards as the single place that needs the SDK fix (handled separately in _build_engine).
bdero
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The macOS
androidshard's Rust step listsaarch64-apple-iosandx86_64-apple-iosalongside the host darwin targets. Those iOS targetsaren't used by anything the android shard links — gen_snapshot is built
for the host (the gn args force
host_cpu="x64"). They're left overfrom the old monolithic
mac_setup.shthat built every macOS variantin one script.
Why this matters now
On the namespace.so macOS Sequoia runner, building updater for
aarch64-apple-iosvia cargo trips an iOS SDK / deployment-targetmismatch and fails the shard outright. Removing the unused targets lets
the android shard go green.
The actual
ios-releaseshards still need the iOS Rust targets;the SDK pin for those is handled separately in
_build_engine(
IPHONEOS_DEPLOYMENT_TARGET=13.0).Test plan
_build_engine'ssharded workflow checks out a tree containing this fix