fix: pass action when using dry run#22
Conversation
| RELEASE_VERSION=$(echo $GREP_MATCH | sed -E 's/^.+ Published Release (.*)\!$/\1/') | ||
| echo "release-version=$(echo $RELEASE_VERSION)" >> $GITHUB_OUTPUT | ||
| # Check if --dry-run or -n is in the args | ||
| if echo "${{ inputs.args }}" | grep -qE -- "(--dry-run|-n\b)"; then |
There was a problem hiding this comment.
echo "${{ inputs.args }}" | grep -qE … interpolates user-controlled args straight into the shell. Same hazard #23 set out to fix on the release-invocation line. A quote, $(…), or backtick in args gets evaluated by the shell before grep ever sees it. Post-rebase, drive this check off the sanitized $ARGS bash variable instead of re-injecting ${{ inputs.args }}.
| run: flutter create e2e_test_dry_run --empty | ||
|
|
||
| - name: 🐦 Shorebird Init | ||
| run: shorebird init --force |
There was a problem hiding this comment.
shorebird init --force here is missing --organization-id, but the existing e2e job needs it (main has --organization-id=46686 after the recent rotation). This new job will probably fail with "Organization with ID '...' not found" or hang on a prompt. Needs the same id.
| runs-on: ${{ matrix.os }} | ||
| steps: | ||
| - name: 📚 Git Checkout | ||
| uses: actions/checkout@v4 |
There was a problem hiding this comment.
Action versions on the new job lag the existing e2e job — actions/checkout@v4 here (and actions/setup-java@v4 on line 101) vs @v6 and @v5 on main after the recent dependabot bump. Worth matching. The two jobs also share ~12 setup steps verbatim, so if we end up keeping both, factoring the common steps into a reusable composite would stop this drift on the next bump.
|
hey @bdero based on this answer I'd close this PR instead: #21 (comment) Adding a way to check programmatically what the latest Flutter version supported by Shorebird is would already solve our problem. |
3 participants
Fixes #21
Not sure if the additional e2e test is wanted or unnecessary overhead. Let me know what you think!