feat(shorebird_cli): add account apps subcommand#3743
Open
nickshorebird wants to merge 2 commits intomainfrom
Open
feat(shorebird_cli): add account apps subcommand#3743nickshorebird wants to merge 2 commits intomainfrom
nickshorebird wants to merge 2 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
shorebird account apps, which lists apps the current user has access to. Mirrors theaccount orgsshape so theaccountnamespace stays parallel (whoami, orgs, apps).codePushClientWrapper.getApps()already used internally by release/patch flows. No new wrapper, protocol, or server work.app_id display_name latest_release_version latest_patch_number, w/-for unreleased apps.--jsonreturns{ apps: [{ app_id, display_name, latest_release_version, latest_patch_number }] }.--helpand then parsing--jsonsees identical field names. Caught while comparing the three account subcommands' help output side-by-side.accountsurface from the agentic smoke test. Remainingaccountcapabilities (org create, member mgmt, API keys, usage/plan, audit logs, transfer-app-to-org) all need backend work and will land separately.Why not a plain
appcommand?I originally planned to have
app, egshorebird app, but each of the app commands are either semantically covered already, egcreatew/release, or logically fit better into account or other parents.Testing
apps_command_test.dart: precondition failure, auth required, populated and empty-state human output, API-error path in human and JSON modes, JSON success shape w/ flat fields, projection check (nocreated_at/updated_atleak), empty-array casedart test packages/shorebird_cli: 2028 passed, 1 skipped (pre-existing), 0 failuresdart analyze --fatal-warnings lib test: clean on new filesdart format: cleanshorebird account appsandshorebird account apps --jsonboth render correctly; forced-unauthenticated path returns the expected JSON error envelope