Switch boto3 s3 client to SigV4 by removing deprecated Signature V2 config#4
Open
sagihirshfeld wants to merge 1 commit intoshpaz:masterfrom
Open
Switch boto3 s3 client to SigV4 by removing deprecated Signature V2 config#4sagihirshfeld wants to merge 1 commit intoshpaz:masterfrom
sagihirshfeld wants to merge 1 commit intoshpaz:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch removes the explicit
signature_version="s3"configuration, which forces the deprecated Signature V2. Modern S3-compatible servers (AWS, RGW, NooBaa) no longer accept SigV2, which resulted in consistentSignatureDoesNotMatcherrors when using this tool against current deployments.
By removing the legacy config, boto3 falls back to its default signing method
(Signature V4), which is compatible with all modern S3 endpoints.