Deprecate MessageState with a new PushProcessMessageErrorJob#14753
Draft
JesseWeinstein wants to merge 1 commit into
Draft
Deprecate MessageState with a new PushProcessMessageErrorJob#14753JesseWeinstein wants to merge 1 commit into
JesseWeinstein wants to merge 1 commit into
Conversation
…names rather than a separate enum
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor checklist
Description
I noticed that the MessageState enum had obsolete entries, and is only used for error cases. This cleans that up, using the underlying class names instead. The existing job is retained, and can be cleaned up in the next version, once there are no more existing jobs using it.
I am not sure this is worth doing, and I haven't tested it yet, but I wanted to put it up for consideration.