Skip to content

Fail CD builds for failed tests#813

Merged
papeh merged 3 commits intomainfrom
fix/tests4CD
Apr 7, 2026
Merged

Fail CD builds for failed tests#813
papeh merged 3 commits intomainfrom
fix/tests4CD

Conversation

@papeh
Copy link
Copy Markdown
Contributor

@papeh papeh commented Apr 6, 2026

This partially reverts commit 67f919a.

  • Include CD test logs in log artifacts

This change is Reviewable

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 6, 2026

NUnit Tests

    1 files  ±0      1 suites  ±0   6m 59s ⏱️ +43s
4 098 tests ±0  4 027 ✅ ±0  71 💤 ±0  0 ❌ ±0 
4 107 runs  ±0  4 036 ✅ ±0  71 💤 ±0  0 ❌ ±0 

Results for commit 60d5372. ± Comparison against base commit 9083a2e.

@jasonleenaylor
Copy link
Copy Markdown
Contributor

build.ps1 line 687 at r1 (raw file):

	# Test Execution (Optional)
	# =============================================================================
	# Run tests BEFORE the installer build because the installer's CleanAll target

These comments probably need an update.

Copy link
Copy Markdown
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@jasonleenaylor reviewed 3 files and made 1 comment.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on papeh).

papeh added 3 commits April 7, 2026 16:03
Running tests last ensures that failed tests cause installer
builds to fail.

This partially reverts commit
67f919a.
@papeh papeh enabled auto-merge (squash) April 7, 2026 21:08
@papeh papeh merged commit 7cb3fe9 into main Apr 7, 2026
5 of 6 checks passed
@papeh papeh deleted the fix/tests4CD branch April 7, 2026 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants