Skip to content

Serena project upgrade#816

Open
johnml1135 wants to merge 2 commits intomainfrom
update_serena
Open

Serena project upgrade#816
johnml1135 wants to merge 2 commits intomainfrom
update_serena

Conversation

@johnml1135
Copy link
Copy Markdown
Contributor

@johnml1135 johnml1135 commented Apr 7, 2026

Just standard upgrade to 1.0


This change is Reviewable

Copilot AI review requested due to automatic review settings April 7, 2026 13:54
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates the Serena project configuration to align with the 1.0 format/schema and refreshed documentation pointers.

Changes:

  • Refreshes the supported language list/comments and simplifies legacy/dated notes.
  • Adds/relocates project metadata and introduces new config keys (prompt, line endings, memory patterns, LS-specific settings).
  • Clarifies gitignore/ignored paths behavior and tool inclusion/exclusion comments.

# line ending convention to use when writing source files.
# Possible values: unset (use global setting), "lf", "crlf", or "native" (platform default)
# This does not affect Serena's own files (e.g. memories and configuration files), which always use native line endings.
line_ending:
Copy link

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If Serena’s config parsing distinguishes between an omitted key (inherit global) and a present-but-null key, line_ending: with no value may not behave like “unset” and could also fail schema validation if an enum/string is expected. Prefer removing the key entirely to inherit the global setting, or set an explicit value (e.g., unset, \"lf\", \"crlf\", or \"native\") consistent with what the 1.0 parser expects.

Suggested change
line_ending:

Copilot uses AI. Check for mistakes.
Comment on lines 130 to 131
# the name by which the project can be referenced within Serena
project_name: FieldWorks
Copy link

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously the config comment indicated project_name was intentionally omitted to avoid worktree conflicts. Setting a fixed project_name can reintroduce collisions when multiple worktrees/instances are used. If worktrees are still part of the workflow, consider omitting project_name again or making it unique per worktree (e.g., derived from folder/worktree name).

Suggested change
# the name by which the project can be referenced within Serena
project_name: FieldWorks

Copilot uses AI. Check for mistakes.
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 7, 2026

NUnit Tests

    1 files  ±0      1 suites  ±0   6m 24s ⏱️ +8s
4 103 tests +5  4 032 ✅ +5  71 💤 ±0  0 ❌ ±0 
4 112 runs  +5  4 041 ✅ +5  71 💤 ±0  0 ❌ ±0 

Results for commit 19cb281. ± Comparison against base commit 7ef7052.

♻️ This comment has been updated with latest results.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
- Per-folder AGENTS.md files describe component contracts and dependencies

# list of tool names to exclude.
# This extends the existing exclusions (e.g. from the global configuration)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this comment go down next to excluded_tools: [] (line 106)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants