Installer: add prerequisites alias for vcredists#820
Open
johnml1135 wants to merge 1 commit intomainfrom
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a backward-compatible WiX PackageGroup alias named prerequisites that forwards to the existing vcredists group, preventing legacy bundle authoring from breaking when it still references prerequisites.
Changes:
- Introduce
PackageGroup Id="prerequisites"as an alias tovcredists - Apply the alias across the tracked redistributables include files used by WiX 3 and WiX 6 authoring
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| FLExInstaller/wix6/Shared/Common/Redistributables.wxi | Adds prerequisites package-group alias forwarding to vcredists for shared WiX 6 authoring. |
| FLExInstaller/wix6/Redistributables.wxi | Adds prerequisites alias for the WiX 6 redistributables include. |
| FLExInstaller/Redistributables.wxi | Adds prerequisites alias for the legacy/alternate redistributables include. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prerequisitespackage-group alias that forwards tovcredistsprerequisitesVerification
./Build/Agent/check-and-fix-whitespace.ps1./Build/Agent/commit-messages.ps1.\build.ps1 -BuildInstaller -Configuration ReleaseThis change is