Centralize shared Build/Src package versions#822
Open
johnml1135 wants to merge 2 commits intomainfrom
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Centralizes NuGet package version management for Build/Src by converting its Directory.Packages.props into a CPM “overlay” that imports the repo root pins, while keeping deliberate build-tool-specific version deltas and ensuring legacy projects can remain opt-out.
Changes:
- Converted
Build/Src/Directory.Packages.propsto import the repo-rootDirectory.Packages.propsand define only Build/Src-specific version overrides. - Removed inline
Version=attributes fromBuild/Src/FwBuildTasks/FwBuildTasks.csprojto rely on central package management. - Explicitly opted
Build/Src/NativeBuild/NativeBuild.csprojout of CPM.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Build/Src/NativeBuild/NativeBuild.csproj | Opts NativeBuild out of CPM explicitly. |
| Build/Src/FwBuildTasks/FwBuildTasks.csproj | Removes inline package versions to use central pins. |
| Build/Src/Directory.Packages.props | Imports root CPM props and defines Build/Src-specific package version deltas. |
johnml1135
commented
Apr 9, 2026
Contributor
Author
johnml1135
left a comment
There was a problem hiding this comment.
Followed up on the two Copilot review points.
- The guarded root CPM import and explicit error path have been implemented locally in Build/Src/Directory.Packages.props.
- The remaining Include versus Update mix is intentional: only the package IDs already defined in the repo-root Directory.Packages.props should use Update in this overlay; Microsoft.Build.Utilities.Core and SIL.BuildTasks are not root-pinned there and must remain Include.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Build/Src/Directory.Packages.propsfrom a CPM opt-out into a CPM overlay that imports the repo rootDirectory.Packages.props.Build/Src/FwBuildTasks/FwBuildTasks.csprojso shared packages resolve from one central declaration.Build/Src/NativeBuild/NativeBuild.csprojout of CPM because it is a traditional MSBuild project that still relies on explicit and property-driven package versions.Why this is needed:
System.Resources.ExtensionsandSystem.Reflection.MetadatainFwBuildTasks.csprojwithout bringing the matching root pins along, which left duplicate shared-version declarations out of sync.CI-ready checklist
.github/commit-guidelines.md(subject ≤ 72 chars, no trailing punctuation; if body present, blank line then ≤ 80-char lines).Src/**folders touched, correspondingAGENTS.mdfiles are updated or explicitly confirmed still accurate.Notes for reviewers (optional)
msbuild "Build\Src\FwBuildTasks\FwBuildTasks.csproj" /restore /t:Build /p:Configuration=Debug /p:Platform=x64 /p:FwBuildTasksOutputPath="BuildTools\FwBuildTasks\Debug\" /p:SkipFwBuildTasksAssemblyCheck=true /p:SkipFwBuildTasksUsingTask=true /p:SkipGenerateFwTargets=true /p:SkipSetupTargets=truemsbuild "Build\Src\NativeBuild\NativeBuild.csproj" /t:Restore /p:Configuration=Debug /p:Platform=x64 /p:SkipSetupTargets=true /p:SkipFwBuildTasksAssemblyCheck=trueThis change is