Conversation
Change-Id: Ib775606f8bfd6beaf8e777044f988472511bf414
papeh
requested changes
Apr 9, 2026
Contributor
papeh
left a comment
papeh
left a comment
There was a problem hiding this comment.
That's great that you already have localizations for de, es, and fr. Rather than checking them into the repo, they should be uploaded to Crowdin. I've sent you an invitation.
papeh
reviewed
Apr 9, 2026
| Console.WriteLine(HCSynthByGlossStrings.ksUsage); | ||
| Console.WriteLine(HCSynthByGlossStrings.ksCommandLineUsage); | ||
| Console.WriteLine(HCSynthByGlossStrings.ksTurnOnTracing); | ||
| Console.WriteLine(HCSynthByGlossStrings.ksShowTracing); |
Contributor
There was a problem hiding this comment.
If these are always used together, I think it would be best to combine them into a single string.
| { | ||
| static void Main(string[] args) | ||
| { | ||
| const int iLocale = 0; |
Contributor
There was a problem hiding this comment.
Clever use of constants to make command line args meaningful!
| <value>HCSynthByGloss locale -h HC.xml_file -g gloss_file -o output (-t (-s))</value> | ||
| </data> | ||
| <data name="ksCouldNotFind" xml:space="preserve"> | ||
| <value>Could not find </value> |
Contributor
There was a problem hiding this comment.
To support languages with different word order, you could use string.Format( with
<data name="ksCouldNotFind" xml:space="preserve">
<value>Could not find {0} '{1}'.</value>
<comment>{0} is 'HC XML file' or 'Gloss file'. {1} is the path to (name of?) the file.</comment>
</data>
| } | ||
| if (duplicateFound) | ||
| { | ||
| sb.Append(" synthesis may not work."); |
Contributor
There was a problem hiding this comment.
This sentence could also be combined into a single string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds English (by default), French, German, and Spanish for the 13 strings used in the HcSynthByGloss tools.
The EXE puts the locale code as its first argument.
The DLL add a property to set the locale code.
This change is