Handle empty TranslationInfo tag properly when parsing Settings.xml#402
Handle empty TranslationInfo tag properly when parsing Settings.xml#402pmachapman wants to merge 1 commit intomasterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #402 +/- ##
==========================================
+ Coverage 73.00% 73.02% +0.01%
==========================================
Files 439 439
Lines 36693 36693
Branches 5038 5039 +1
==========================================
+ Hits 26789 26794 +5
+ Misses 8789 8787 -2
+ Partials 1115 1112 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ddaspit
left a comment
There was a problem hiding this comment.
I think it would be helpful to have a test fixture for ParatextProjectSettingsParserBase to test this kind of logic. We can create a memory-based implementation for testing purposes. MemoryParatextProjectFileHandler already exists.
@ddaspit reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on Enkidu93).
Enkidu93
left a comment
There was a problem hiding this comment.
@Enkidu93 reviewed 1 file and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on pmachapman).
e690bc5 to
deb7e5f
Compare
pmachapman
left a comment
There was a problem hiding this comment.
I think it would be helpful to have a test fixture for
ParatextProjectSettingsParserBaseto test this kind of logic. We can create a memory-based implementation for testing purposes.MemoryParatextProjectFileHandleralready exists.
Thanks - done.
@pmachapman made 1 comment.
Reviewable status: 1 of 4 files reviewed, all discussions resolved (waiting on ddaspit and Enkidu93).
Fixes #401.
I tested by modifying the Settings.xml file manually. If you think this should have its own test, we will need another test project in the file system, as none of the file system calls go through an abstraction layer.
This change is