Skip to content

Conversation

@kzscisoft
Copy link
Collaborator

Find simvue.toml in nested directories

Issue: N/A

Python Version(s) Tested: 3.13

Operating System(s): Ubuntu 25.10

📝 Summary

Locates simvue.toml from parent as well as current directories.

🔄 Changes

Expanded find_first_instance_of_file.

✔️ Checklist

  • Unit and integration tests passing.
  • Pre-commit hooks passing.
  • Quality checks passing.
  • Updated the documentation.

@kzscisoft kzscisoft added this to the Simvue Python API v2.3 milestone Jan 28, 2026
@kzscisoft kzscisoft added the enhancement New feature or request label Jan 28, 2026
@james-panayis
Copy link
Collaborator

I've made a slight tweak so that it doesn't keep endlessly rechecking the root dir ("/") if the user has read access all the way up to it. It'd be good to have a test that hits that case (which I think is quite common). I'd probably do it by mocking .parent to return self, but there's other ways it could be done too.

This seems to work exactly as expected now, and will be extremely useful for users 😄

Co-authored-by: James Panayis <james.panayis@ukaea.uk>
@kzscisoft kzscisoft force-pushed the feature/find-nearest-config branch from 79437b2 to 9638221 Compare January 29, 2026 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants