DEVEXP-1145: Number Lookup Snippet #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asein-sinch
approved these changes
Dec 2, 2025
JPPortier
reviewed
Dec 2, 2025
| @@ -0,0 +1,18 @@ | |||
| import os | |||
There was a problem hiding this comment.
Could be fine to add some context; like from other SDKs:
- https://github.com/sinch/sinch-sdk-java-snippets/blob/main/snippets/src/main/java/numbers/CheckAvailability.java#L1-L7
- https://github.com/sinch/sinch-sdk-node/blob/v1.4-next/docs/snippets/numbers/active-numbers/get.js#L1-L4
Will be available from online doc
Contributor
Author
There was a problem hiding this comment.
Will open a new PR
| ) | ||
|
|
||
| # The phone number to lookup | ||
| phone_number = "+1234567890" |
There was a problem hiding this comment.
Other snippets are mainly based onto placeholders.
e.g.:
- https://github.com/sinch/sinch-sdk-java-snippets/blob/main/snippets/src/main/java/numbers/Rent.java#L35
- https://github.com/sinch/sinch-sdk-node/blob/v1.4-next/docs/snippets/voice/callouts/tts.js#L14
What do you think about keeping same rule for Python SDK ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.