feat: add Windows support and clean up codebase #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add Windows compatibility for terminal width detection - Remove console.error statements for cleaner output - Remove DEBUG_FONT_INSTALL debug code - Remove unnecessary react-devtools-core dependency - Fix TypeScript/ESLint warnings - Add .gitattributes for consistent line endings (LF) - Improve error handling with silent failures Tested on Windows 11. Unable to test on macOS/Linux platforms.
Owner
|
I'll have to review this a bit tomorrow. I notice you took out the terminal width detection method I was using for POSIX compliant systems. The reason that was in place is because when claude code runs the statusline as a subprocess, the statusline has no ability to directly access TTY properties, so any standard terminal width detection will always report the width as 80 columns. The method I had in place works on POSIX systems to find the parent process's TTY and get the actual width using stty. It's a messy hack, but it's the only option right now to get the full terminal width accurately until Anthropic decides to put it in the JSON passed to the process. |
sirmalloc
force-pushed
the
main
branch
2 times, most recently
from
c440de6 to
8e6b101
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on Windows 11. Unable to test on macOS/Linux platforms.