Skip to content

fix br#720

Open
makhin wants to merge 2 commits intosjh37:masterfrom
makhin:master
Open

fix br#720
makhin wants to merge 2 commits intosjh37:masterfrom
makhin:master

Conversation

@makhin
Copy link
Copy Markdown
Contributor

@makhin makhin commented Sep 13, 2021

Sorry. Thanks for review.

@sjh37
Copy link
Copy Markdown
Owner

sjh37 commented Mar 27, 2026

This PR does the following:

  1. UsePascalCaseForEnumMembers setting — new bool to control PascalCase for enum member names independently of UsePascalCase.
  2. EnumNameField / EnumValueField settings — configurable column names for enum source tables (defaults: "Name" / "Id").
  3. UpdateEnum / UpdateEnumMember callbacks — new Action<> hooks in Settings so users can customize enums/enum members before generation (analogous to UpdateColumn).
  4. Enumeration filtersEnumerationTableFilters and EnumerationSchemaFilters added to FilterSettings, with AddDefaultEnumerationTableFilters() / AddDefaultEnumerationSchemaFilters() and corresponding filter classes (EnumerationTableFilter, EnumerationSchemaFilter).
  5. VSIX target framework bump.csproj updated from v4.5v4.8.
  6. .ttinclude updated — all the above reflected in the generated file.

This adds useful enum customisation hooks that don't exist today. The main concerns before merging would be:

  • The .ttinclude was edited directly (violates the build process — it should be regenerated from Generator/).
  • It may not have corresponding changes in Generator/ source files.
  • No tests included.

It's not merge-ready as-is, but the feature idea has value.
Leaving open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants