Tech 5378 aetherlay rpc endpoints #40
Conversation
chong-techops
requested review from
a team,
OleksandrUA,
drama17,
eskp,
jpedrosa94,
nickkounz,
sanbotto and
zdumitru
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@chong-techops the change looks good to me. however you may need to update the aetherlay endpoint to prod once it has been deployed. because these are all for production usage. |
sanbotto
left a comment
sanbotto
left a comment
There was a problem hiding this comment.
It looks good, but we should create a ticket or do something to make sure we remember to update chain.techops.live to chain.techops.services once we deployed to prod. I think that the default should be prod since it's gonna be more stable.
| elif chain == "sepolia": | ||
| endpoint = "https://chain.techops.live/eth-sepolia" | ||
| else: | ||
| endpoint = "https://chain.techops.live/eth-{}".format(chain) |
There was a problem hiding this comment.
This probably should be:
| endpoint = "https://chain.techops.live/eth-{}".format(chain) | |
| endpoint = "https://chain.techops.live/{}".format(chain) |
There was a problem hiding this comment.
A ticket has been created for the following update: https://techopsservices.atlassian.net/browse/TECH-5394
Regarding the chain variable, there's no eth- prefix.
|
This PR can't be merged due to CORS error. Similar issue on keeperhub staging as well. |
No description provided.