fix: handle the exclude boundary logic of the memory table #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyzh
approved these changes
May 5, 2025
Owner
skyzh
left a comment
skyzh
left a comment
There was a problem hiding this comment.
Overall LGTM but I might need to revisit the book before merging this patch. The for_testing_X method is supposed to be provided and should not be changed across the course.
Signed-off-by: Alex Chi <[email protected]>
yuoknow
pushed a commit
to yuoknow/mini-lsm
that referenced
this pull request
Jun 1, 2025
* fix: handle the exclude boundary logic of the memory table * add comments Signed-off-by: Alex Chi <[email protected]> --------- Signed-off-by: Alex Chi <[email protected]> Co-authored-by: Alex Chi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scan method does not handle the exclude boundary logic of the memory table.