Fix deprecated file upload methods with modern Slack API#1473
Fix deprecated file upload methods with modern Slack API#1473RajaPremSai wants to merge 2 commits intoslack-go:masterfrom
Conversation
|
Hi maintainers! 👋 I've successfully updated this branch with the latest changes from master. This PR is ready for review and addresses important issues with deprecated file upload methods in the Slack API. Actions completed: Pending items that require maintainer action: This PR fixes critical functionality by replacing deprecated Thanks for your time reviewing this contribution! 🙏 |
|
Hi maintainers! 👋 I've successfully updated this branch with the latest changes from master. This PR is ready for review and addresses important issues with deprecated file upload methods in the Slack API. Actions completed: Pending items that require maintainer action: This PR fixes critical functionality by replacing deprecated files.upload endpoints with the modern 3-step upload process, maintaining backward compatibility while providing working alternatives. Thanks for your time reviewing this contribution! 🙏 |
|
I know you're well intentioned here but this isn't a PR I'm inclined to review with current state. It has a bunch of changes I don't like, namely:
Basically, if there are methods that are broken, let's fix them rather than add new ones. |
Fix deprecated file upload methods with modern Slack API
Problem
The
UploadFile()andUploadFileV2()methods are broken due to deprecated Slack API endpoints and parameter validation issues:UploadFile()returnsmethod_deprecatederrorsUploadFileV2()has type mismatches and parameter issuesfiles.uploadendpointSolution
FixedUploadFile()andFixedUploadFileV2()methods using modern 3-step upload processfiles.getUploadURLExternal→ direct upload →files.completeUploadExternalFiles Changed
files_v2_fixed.go- New fixed methodsfiles_v2_fixed_test.go- Tests for new methodsexamples/file_upload_fix_example.go- Working examplesfiles.go- Deprecation warningsTesting
All tests pass. The new methods work with the current Slack API.
Migration
Users can replace:
api.UploadFile(params)→api.FixedUploadFile(params)api.UploadFileV2(params)→api.FixedUploadFileV2(params)The old methods remain available with deprecation warnings.