chore(block-kit): prefer pyproject.toml over requirements.txt#57
Draft
slack-samples[bot] wants to merge 1 commit intomainfrom
Draft
chore(block-kit): prefer pyproject.toml over requirements.txt#57slack-samples[bot] wants to merge 1 commit intomainfrom
slack-samples[bot] wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Summary
Move the Block Kit example from
requirements.txttopyproject.tomlso its runtime and development dependencies live in the standard Python project metadata file.This keeps Dependabot focused on the existing
block-kitpip manifest location while letting local and CI setup install the sample withpip install -e ".[dev]". The runtime dependency remainsslack_sdk==3.41.0; lint, type-check, and test tools are preserved as thedevextra.Related discussion: slack-samples/bolt-python-getting-started-app#7 tracks the shared
pyproject.tomlvsrequirements.txtdiscussion for this Python batch.Reviewers
Please verify the Block Kit example still installs and runs checks from its nested directory:
Slack CLI app creation check (using the nested Block Kit example):
Requirements
Sources
pyproject.tomlas the build-system configuration file for Python projects.pyproject.toml.pyproject.tomlas the modern place for project metadata.pyproject.toml, including editable installs with extras.