Do not use subclasses of CompletableFuture to catch cancel

[FroMage]

We can catch it via normal callbacks, this lets us use the proper wrapped CF from SR-CP.

Draft because SR-CP has not been released yet.

[jponge]

Looks good to me @FroMage

When this is ready I'll ask you to remake the commit with https://www.conventionalcommits.org/en/v1.0.0/#summary

[FroMage]

This better?

[jponge]

This better?

fix: do not (...) (must start lowercase for the first word, I know I know ...)

[FroMage]

It would be nice if you had a bot that extracted the failure of the check into a comment, that's much easier for people to iterate on this :)

[jponge]

I think the action logs do have a clue of why it failed, but yeah, that's the annoying part and you're entitled to complain 🤣

For the rest I love this practice: cherry-picking for hot fix branches, generating changelogs, etc.

[FroMage]

The practice is fine. I'm saying a bot can extract the failure from CI and add it here as a comment, like we do in Quarkus, that makes it easier for contributors to see the error and fix it faster.

[FroMage]

SR-CP is released so let's run this CI.

[codecov]

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 89.14%. Comparing base (8c94ac3) to head (bcec086).
⚠️ Report is 34 commits behind head on main.

Files with missing lines	Patch %	Lines
...y/operators/uni/UniSubscribeToCompletionStage.java	83.33%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #2011      +/-   ##
============================================
- Coverage     89.15%   89.14%   -0.01%     
+ Complexity     3070     3068       -2     
============================================
  Files           409      409              
  Lines         13100    13100              
  Branches       1652     1652              
============================================
- Hits          11679    11678       -1     
- Misses          805      807       +2     
+ Partials        616      615       -1     

Files with missing lines	Coverage Δ
...y/operators/uni/UniSubscribeToCompletionStage.java	75.00% <83.33%> (-6.82%)	⬇️

... and 10 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[jponge]

I'll merge and release later today

[FroMage]

😬