feat: add --no-quarantine flag to upstream import and fix docs#313
Merged
feat: add --no-quarantine flag to upstream import and fix docs#313
Conversation
Fix A: Documentation incorrectly used `mcpproxy import` instead of `mcpproxy upstream import`, wrong flags (--path, --preview, --servers). Fixed in config-import.md and command-reference.md with correct syntax. Feature A: Add --no-quarantine flag to `mcpproxy upstream import` matching existing `upstream add --no-quarantine` pattern. Opt-in flag preserves security-by-default (quarantine ON). Override applied at Import() layer after mapper sets secure default. Added tests for both behaviors. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Deploying mcpproxy-docs with
|
| Latest commit: |
2506cad
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1f34e564.mcpproxy-docs.pages.dev |
| Branch Preview URL: | https://feat-import-skip-quarantine.mcpproxy-docs.pages.dev |
📦 Build ArtifactsWorkflow Run: View Run Available Artifacts
How to DownloadOption 1: GitHub Web UI (easiest)
Option 2: GitHub CLI gh run download 22525669386 --repo smart-mcp-proxy/mcpproxy-go
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mcpproxy importinstead ofmcpproxy upstream import, and had wrong flags (--pathinstead of positional arg,--previewinstead of--dry-run,--serversinstead of--server). Fixed inconfig-import.mdandcommand-reference.md.--no-quarantineflag tomcpproxy upstream importso imported servers skip quarantine. Matches existingupstream add --no-quarantinepattern. Opt-in flag preserves security-by-default.Changes
cmd/mcpproxy/upstream_cmd.go— added--no-quarantineflag, wired to ImportOptions, addedquarantinedto JSON output, updated daemon mode to use server's quarantine stateinternal/configimport/types.go— addedSkipQuarantinefield to ImportOptionsinternal/configimport/import.go— override quarantine after mapper when flag setinternal/configimport/import_test.go— 2 new tests for default and skip behaviorsdocs/features/config-import.md— corrected CLI syntax and flagsdocs/cli/command-reference.md— corrected CLI syntax, flags, and examplesDesign decisions
--no-quarantine— matches existingupstream add --no-quarantineImport()after mapper sets secure default, keepingmapper.gountouchedTest plan
go test -race ./internal/configimport/...— 53 tests passgo build ./cmd/mcpproxy/...— compiles./mcpproxy upstream import --help— shows new flagmcpproxy upstream import --dry-run --no-quarantine <config>— verify output shows servers not quarantined🤖 Generated with Claude Code