Skip to content

Conversation

@agparadiso
Copy link
Contributor

@agparadiso agparadiso commented Nov 12, 2025

Description

This is the current problem:
  • When a workflow engine is created (v2/engine.go), the beholder logger is initialised once with initial labels including platform.DonVersion set to the current.
  • The node periodically syncs with the capability registry (via registrysyncer)
  • When the registry sync occurs, the local node's workflow DON information may be updated, including a new ConfigVersion
  • The engine detects this change and updates its internal localNode
  • However, the beholder logger was created with the initial labels and continues to use the old DonVersion value
The fix:

To keep it simple we create a new beholder logger instance whenever the workflow DON configuration changes, replacing the old logger in the engine.

CRE-1188

Requires

Supports

@github-actions
Copy link
Contributor

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@agparadiso agparadiso changed the title [CRE-1188] Update platform.don version whenever there is a DON config change [CRE-1188] Update platform.donVersion whenever there is a DON config change Nov 12, 2025
@agparadiso agparadiso force-pushed the fix/CRE-1188_update_platform.DonVersion branch from 1f45e12 to 87c352e Compare November 12, 2025 18:10
@agparadiso agparadiso force-pushed the fix/CRE-1188_update_platform.DonVersion branch from 87c352e to c5331a6 Compare November 12, 2025 19:01
@trunk-io
Copy link

trunk-io bot commented Nov 12, 2025

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

@agparadiso agparadiso force-pushed the fix/CRE-1188_update_platform.DonVersion branch from fa74cb6 to 2812616 Compare November 13, 2025 13:56
@cl-sonarqube-production
Copy link

@agparadiso agparadiso marked this pull request as ready for review November 13, 2025 15:46
@agparadiso agparadiso requested a review from a team as a code owner November 13, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant