fix: skips gateway connector startup if config is invalid

[MStreet3]

it is currently possible to attempt to start the gateway connector service with an invalid config, which generally happens when starting without providing a valid NodeAddress. this fails the node immediately with a cryptic message. instead we will skip service startup if the config is invalid, which allows the node to boot and for operators to determine the node address.

Requires

Supports

[github-actions]

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

• #added For any new functionality added.
• #breaking_change For any functionality that requires manual action for the node to boot.
• #bugfix For bug fixes.
• #changed For any change to the existing functionality.
• #db_update For any feature that introduces updates to database schema.
• #deprecation_notice For any upcoming deprecation functionality.
• #internal For changesets that need to be excluded from the final changelog.
• #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
• #removed For any functionality/config that is removed.
• #updated For any functionality that is updated.
• #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

[cl-sonarqube-production]

Quality Gate failed

Failed conditions
D Maintainability Rating on New Code (required ≥ A)
43.17% Technical Debt Ratio on New Code (required ≤ 4%)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarQube IDE

[krehermann]

what observability can we emit to alleviate the partial config scenario?

it's good that the node will boot; but it won't function correctly. my concern is that we will make it even easier to misconfigure the system and it won't be able to detect it. maybe a simple library that emits feature enable metrics that is integrated in the Start call of the service lib; so that any StartOnce emits a node uuid and service name.

Or perhaps we can leverage existing HealthCheck abstraction to do something similar. I'd rather have the Service attempt to start, detect partial config, and report itself in a bad state.

@jmank88 wdyt?

[trunk-io]

     

View Full Report ↗︎ ⋅ Docs