-
Notifications
You must be signed in to change notification settings - Fork 151
SNOW-2070718 move BLOCKED querystatus to the Running ones to conform JDBC and Python #1166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
sfc-gh-dszmolka
wants to merge
6
commits into
master
Choose a base branch
from
SNOW-2070718-blocked-querystatus-is-still-running
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
SNOW-2070718 move BLOCKED querystatus to the Running ones to conform JDBC and Python #1166
sfc-gh-dszmolka
wants to merge
6
commits into
master
from
SNOW-2070718-blocked-querystatus-is-still-running
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
❌ 2 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, we consider BLOCKED querystatus as an Error; which is a weird divergence from other Snowflake drivers, which consider it still Running.
Some examples:
On the other hand, Go, Node.js, and libsnowflakeclient (= ODBC) drivers doesn't consider it as Running, so we might want to fix those too - or, make JDBC and Python consider BLOCKED as Error, to stop the drivers being divergent on this.
Traditionally, I think JDBC came first and perhaps the weird implementation which led to this divergence.
Anyhow. The definition of BLOCKED status:
which by definition, if it's waiting on something, then it's still running and not in an end state.
Checklist
dotnet test)