Skip to content

Conversation

@sfc-gh-mgemra
Copy link
Collaborator

@sfc-gh-mgemra sfc-gh-mgemra commented Nov 7, 2025

Description

SNOW-2684090 Validate NextUpdate for freshly downloaded CRLs

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@codecov
Copy link

codecov bot commented Nov 7, 2025

Codecov Report

❌ Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.05%. Comparing base (e4d8466) to head (1884cc7).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...a/Core/Revocation/CertificateRevocationVerifier.cs 77.77% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1277   +/-   ##
=======================================
  Coverage   88.05%   88.05%           
=======================================
  Files         192      192           
  Lines       15780    15789    +9     
  Branches     1633     1635    +2     
=======================================
+ Hits        13895    13903    +8     
+ Misses       1469     1466    -3     
- Partials      416      420    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-mgemra sfc-gh-mgemra force-pushed the mgemra/crl-fresh-crl-is-expired branch 2 times, most recently from de4bd31 to eafbf32 Compare November 7, 2025 15:39
@sfc-gh-mgemra sfc-gh-mgemra force-pushed the mgemra/crl-fresh-crl-is-expired branch from 16a2c55 to dc24a7d Compare November 7, 2025 17:07
@sfc-gh-mgemra sfc-gh-mgemra marked this pull request as ready for review November 12, 2025 13:43
@sfc-gh-mgemra sfc-gh-mgemra requested review from a team as code owners November 12, 2025 13:43
@sfc-gh-mgemra sfc-gh-mgemra merged commit dfc1695 into master Nov 13, 2025
160 of 170 checks passed
@sfc-gh-mgemra sfc-gh-mgemra deleted the mgemra/crl-fresh-crl-is-expired branch November 13, 2025 15:42
@github-actions github-actions bot locked and limited conversation to collaborators Nov 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants