[LocalLiveView] Generator tests#616
Open
FranekKubis wants to merge 13 commits into
Open
Conversation
mat-hek
requested changes
May 28, 2026
Contributor
mat-hek
left a comment
There was a problem hiding this comment.
Let's add an integration test, that runs mix phx.new, adds llv to deps, updates home.html.heex, runs llv.install, mix setup and mix phx.server, visits the page with playwright and checks if HelloLocal renders properly
1f924b1 to
da6a135
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mix llv.install(test/mix/tasks/llv_install_test.exs) — one test perinject_*step +generate_local_project+ idempotency, usingIgniter.Test.phx_test_project().mix teststep added to.github/workflows/local_live_view_build.yml.Side effect: a few
inject_*steps used real-FS path checks and silently no-op'd outside the target project's cwd — refactored to Igniter's virtual-FS APIs.Test plan
mix llv.installstill works on a freshphx.newproject