fix: replace Wallet class import with inline KeypairWallet for browser compatibility#84
Open
babuClawd wants to merge 1 commit intosolana-developers:mainfrom
Open
Conversation
…er compatibility The `Wallet` class re-exported from `@coral-xyz/anchor` is actually `NodeWallet`, which is only available in CJS/Node builds. In browser environments (e.g. Vite), importing it causes: ERROR: No matching export in '@coral-xyz/anchor/dist/browser/index.js' for import 'Wallet' Replace with a minimal inline `KeypairWallet` class that implements the same `Wallet` interface (signTransaction, signAllTransactions, publicKey). This makes the helpers package work in both Node and browser environments. Fixes solana-developers#81
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Since v2.8.1, using
@solana-developers/helpersin browser environments (e.g. with Vite) fails with:The
Walletclass exported from@coral-xyz/anchoris actuallyNodeWallet, which is only included in the CJS/Node bundle—not the browser bundle. PR #80 switched fromNodeWallettoWallet, which fixed CJS but broke ESM/browser builds.Solution
Replace the
Walletclass import with a minimal inlineKeypairWalletclass that implements the same interface (signTransaction,signAllTransactions,publicKey). This is a ~30-line class that:Keypair(same asNodeWallet)Walletinterface expected byAnchorProviderWhy not just use
NodeWallet?NodeWalletusesrequire('process')andrequire('fs')in itsstatic local()method, which breaks in browsers. The inline implementation avoids this entirely.Fixes #81