-
-
Notifications
You must be signed in to change notification settings - Fork 53
Fix screen rendering issues #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Fixed a lot of the issues but still have a few cursor movement problems with Ngrok. Will need to capture some Ngrok output and try to make the emulator render it faithfully |
|
This is not ready yet. There are still several failing tests. I think we'll have to switch to using arrays as the character buffer instead of strings. |
Co-authored-by: Hambrook <[email protected]>
|
@aarondfrancis - Just pulled these latest changes; you're making some good ground on the fix. You may already be aware, either way I'll document here, in case your not & want to work on it this branch. Otherwise, I'm happy to add them in as seperate issues to be looked at once this fix is merged and we can work on it afterwards.
|
|
@CamKem keep em coming! I think I've almost cracked it. I'll add tests for the "about" thing, and I've noticed one or two other line issues, so I miiiiight be able to isolate it |
|
@CamKem I pulled part of your backspace fix from #72. I added a few tests for backspace and delete, but weirdly the tests only pass without the replacement of the delete character. I'm not entirely sure what the correct behavior should be, but this matches the iTerm implementation. You can see the diff here: 10a9e32 |
|
@CamKem you wanna put this through its paces before I merge it in? I think I fixed most of the issues (famous last words) |
@aarondfrancis looks pretty good, however still a couple of issues persisting. Honestly they maybe edge cases that the time invested would outweigh the benefit gained at this point, i'll leave that up to you. Alternatively we can add these as seperate issues to be worked on after this is merged, so you can tag a more stable release with the work you have done.
|
@aarondfrancis - Interesting, I went off the VT100 / GNUReadline key mappings (https://www.gnu.org/software/bash/manual/html_node/Readline-Bare-Essentials.html) which should work as the Thanks for the heads up, can look further into it on my PR if need be. |






No description provided.