Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
this PR adds an
anttarget for building the Yices library on macOS. We can't currently ship the binary due to a lack of Apple hardware and the signing issue. However, the script allows users to at least build the binaries themselvesI've tested this on my JavaSMT fork with a github runner and was able to build the binaries and then run the tests
@kfriedberger
We could also include some of the changes I made to the CI on my fork. Building the Yices binaries separately adds 5-10 minutes to each test run, so we should probably limit it to just one Java version on macOS
Do you think it's worth the extra trouble?