Add a way to log toolshed commands, and vv#6505
Open
Geekyhobo wants to merge 3 commits intospace-wizards:masterfrom
Open
Add a way to log toolshed commands, and vv#6505Geekyhobo wants to merge 3 commits intospace-wizards:masterfrom
Geekyhobo wants to merge 3 commits intospace-wizards:masterfrom
Conversation
moonheart08
suggested changes
Mar 31, 2026
Contributor
There was a problem hiding this comment.
Shouldn't this be higher level i.e. at the IConsoleHost layer? The user can, in other circumstances (i.e. custom toolshed executors) just put their own stuff around their toolshed invocations themselves.
Also don't mention admin tooling specific uses in engine, engine doesn't know what that is.
Geekyhobo
force-pushed
the
toolshed-command-invoked-event
branch
from
aef7ea1 to
f74b645
Compare
Geekyhobo
force-pushed
the
toolshed-command-invoked-event
branch
from
f74b645 to
ea76003
Compare
moonheart08
approved these changes
Mar 31, 2026
Contributor
moonheart08
left a comment
moonheart08
left a comment
There was a problem hiding this comment.
bodge-y but so is the entire ServerConsoleHost. rewrite eventually.
Author
|
This now also support vv logging |
Geekyhobo
changed the title
Open
2 tasks
PJB3005
requested changes
May 5, 2026
Member
PJB3005
left a comment
PJB3005
left a comment
There was a problem hiding this comment.
I am not sure what all these mentions of AdminLog are supposed to do but they certainly do not belong in engine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a way to log toolshed commands that are run on the server, and vv