IHandleableEvent and ICancelableEvent Interfaces for events to use.#6522
Open
Princess-Cheeseballs wants to merge 3 commits intospace-wizards:masterfrom
Open
IHandleableEvent and ICancelableEvent Interfaces for events to use.#6522Princess-Cheeseballs wants to merge 3 commits intospace-wizards:masterfrom
Princess-Cheeseballs wants to merge 3 commits intospace-wizards:masterfrom
Conversation
Princess-Cheeseballs
requested review from
DrSmugleaf and
PJB3005
as code owners
moonheart08
suggested changes
Apr 9, 2026
Tayrtahn
reviewed
Apr 9, 2026
Co-authored-by: Tayrtahn <tayrtahn@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added IHandleableEvent and ICancelableEvent interfaces which are intended to be implemented by events in content and eventually engine to replace the HandleableEntityEventArgs and CancelableEntityEventArgs.
As such those two classes have been marked obsolete
Why?
Some systems in content care about events being handled to cancelled and there's not unified way to handle these events, this poses problems for potential construction system refactors and the like which need to handle a lot of events and check if they've been cancelled/handled/ect. or event relays which often explicitly check for handling/canceling to cut off the relay early.
This is problematic as most new events are by ref structs due to their better performance, and they cannot inherit from these old classes. They can however implement interfaces, hence the need for such interfaces.
This PR only makes these interfaces and marks the old events obsolete as moving engine events to these interfaces would break content pretty badly, we should have at least an engine release or many with these available before we start breaking content by properly getting rid of the old args.